[Freeciv-Dev] [patch #7749] Rename gtk3x-client as gtk3.22-client

[Marko Lindqvist]

URL:
<http://gna.org/patch/?7749>

Summary: Rename gtk3x-client as gtk3.22-client
Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 02 Oct 2016 10:42:48 AM EEST
Category: bootstrap
Priority: 5 - Normal
Status: In Progress
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 3.0.0
Contains string changes: None

_______________________________________________________

Details:

The motivation of this ticket comes from gtk+ project's new development model,
and its transition phase. Gtk+-3.22 is the last version starting with '3',
i.e., it's the first stable version of the new system (thought it's not x.0
due to already used version numbers in 3.x series).

https://blog.gtk.org/2016/09/01/versioning-and-long-term-stability-promise-in-gtk/

I think gtk+-3.22 is now the target towards which our current gtk3x-client has
been developed. Thus it should be renamed as gtk3.22-client. This would also
free name 'gtk3x-client' which we are likely to use soon again for building
client against gtk+-3.9x development versions and eventually gtk+-4.0.





_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #1, patch #7749 (project freeciv):

I would progress with plan like this:

1) Rename directories and files gtk3x -> gtk3.22 already before S3_0
branching
2) After S3_0 branching, copy gtk3.22-client as base for new gtk3x-client in
TRUNK. At this point both clients have internal strings talking about "gtk3x"
3) Change internal strings etc in gtk3.22-client from "gtk3x" to "gtk3.22".
Apply patch both to TRUNK and S3_0.

The idea is to avoid changing strings twice. Also things like client option
names should follow this same pattern.

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #7749 (project freeciv):

Depends on: => patch #7750


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #7749 (project freeciv):

Depends on: => patch #7790


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #7749 (project freeciv):

Planned Release: 3.0.0 => 3.0.0, 3.1.0

_______________________________________________________

Follow-up Comment #2:

Finalizing patch for S3_0 now that it's likely that gtk4-client cannot be
ported there in the future (would require big changes to client-common code).

In addition to applyin the patch, 'svn rm' m4/gtk3x-client.m4

(file #29791)
_______________________________________________________

Additional Item Attachment:

File name: CleanOutGtk3x-S3_0.patch Size:0 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #7749 (project freeciv):

Status: In Progress => Ready For Test

_______________________________________________________

Follow-up Comment #3:

Correct (full) patch for S3_0

(file #29821)
_______________________________________________________

Additional Item Attachment:

File name: CleanOutGtk3x-S3_0-2.patch Size:5 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #7749 (project freeciv):

Status: Ready For Test => Done
Assigned to: None => cazfi
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #5:

TRUNK part handled at hostedredmine:
http://www.hostedredmine.com/issues/647949

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?7749>

_______________________________________________
Message sent via/by Gna!
http://gna.org/