[Freeciv-Dev] [bug #23991] Turn never finishing when last client to do turn done under AI control

[Marko Lindqvist]

URL:
<http://gna.org/bugs/?23991>

Summary: Turn never finishing when last client to do turn
done under AI control
Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 10:09:47 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.5.2, 2.6.0, 3.0.0

_______________________________________________________

Details:

Extracted server part from patch of bug #22786, where the part is explained
as:

"Count client with AI controlled player as "connection under control" if it
already has made properly ended turn, when checking against game going
rampant*

*) It's possible to construct corner-cases where this is arguably wrong, but
in general I think this works better than old code that could lead server
never to finish turn if the last turn done was from a client switching under
AI control, and there was no other clients connected at the time."




_______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 27 Oct 2015 10:09:47 PM EET Name:
PhaseDoneIsControlledConnection.patch Size: 569B By: cazfi

<http://gna.org/bugs/download.php?file_id=25493>

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #1, bug #23991 (project freeciv):

I think we've hit this bug after voting about /aitoggle. At least once in such
a situation I had to resolt to temporarily turning timeout on to force one
turn change that way.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #2, bug #23991 (project freeciv):

- New version for TRUNK, updated against svn. Other branches can still use the
original patch

(file #25538)
_______________________________________________________

Additional Item Attachment:

File name: PhaseDoneIsControlledConnection-2.patch Size:0 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #3, bug #23991 (project freeciv):

I now failed to setup the failing case this patch was meant for...

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #23991 (project freeciv):

Status: Ready For Test => In Progress


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #23991 (project freeciv):

Planned Release: 2.5.2, 2.6.0, 3.0.0 => 2.5.x, 2.6.0, 3.0.0


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #23991 (project freeciv):

Status: In Progress => Wont Fix
Assigned to: None => cazfi
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #4:

Splitting this from bug #22786 made no real sense - the bug won't happen as
long as client is not even sending turn done for AI players.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23991>

_______________________________________________
Message sent via/by Gna!
http://gna.org/