Discussion:
[Freeciv-Dev] [bug #25282] handle_unit_get_actions() may leak city existence
Sveinung Kvilhaugsvik
2016-11-10 16:59:54 UTC
Permalink
Update of bug #25282 (project freeciv):

Depends on: => patch #7974


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2016-11-10 17:01:08 UTC
Permalink
Update of bug #25282 (project freeciv):

Depends on: => patch #7975


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2016-11-10 17:10:02 UTC
Permalink
Follow-up Comment #1, bug #25282 (project freeciv):

Patch #7974 fixes the case where this bug, given a potentially legal city
targeted action with long enough range, can be used to discover new cities.

I'm working on the case where a city's disappearance can be detected.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-19 10:27:36 UTC
Permalink
Update of bug #25282 (project freeciv):

Status: In Progress => Ready For Test

_______________________________________________________

Follow-up Comment #2:

Work in progress patch.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-19 10:28:28 UTC
Permalink
Follow-up Comment #3, bug #25282 (project freeciv):

The previous comment was old state. Ready for test patch.

(file #29892)
_______________________________________________________

Additional Item Attachment:

File name: 0015-unit_get_actions-stop-city-existence-leakage.patch Size:3 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-22 18:34:46 UTC
Permalink
Update of bug #25282 (project freeciv):

Planned Release: 3.0.0 => 3.1.0, 3.0.0

_______________________________________________________

Follow-up Comment #4:

v2: Don't leak when city id belongs to a city that used to be on a different
tile than target tile.

(file #29897)
_______________________________________________________

Additional Item Attachment:

File name: 0004-unit_get_actions-stop-city-existence-leakage.patch Size:4 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-22 18:53:27 UTC
Permalink
Update of bug #25282 (project freeciv):

Status: Ready For Test => In Progress


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-26 17:14:41 UTC
Permalink
Update of bug #25282 (project freeciv):

Status: In Progress => Ready For Test

_______________________________________________________

Follow-up Comment #5:

v3:
* improved comments
* drop target city tile != target tile. It is now impossible.
* reorganize probability calculation for clarity

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-26 17:14:54 UTC
Permalink
Additional Item Attachment, bug #25282 (project freeciv):

File name: 0001-unit_get_actions-stop-city-existence-leakage.patch Size:4 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/
Sveinung Kvilhaugsvik
2017-03-28 20:04:23 UTC
Permalink
Update of bug #25282 (project freeciv):

Status: Ready For Test => Fixed
Open/Closed: Open => Closed


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25282>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Loading...