[Freeciv-Dev] [bug #24628] No warning given when saving fails

[Christian Knoke]

URL:
<http://gna.org/bugs/?24628>

Summary: No warning given when saving fails
Project: Freeciv
Submitted by: chrisk
Submitted on: So 01 Mai 2016 12:57:41 CEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.5.1
Discussion Lock: Any
Operating System: GNU/Linux
Planned Release:

_______________________________________________________

Details:


When saving the game goes fail - reason here a full disk - the user sees no
warning. Either with auto save or manual save.

Of course, there is a small red line with english text in the chat window,
which you never will open in a single player game.

Christian





_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Nachricht gesendet von/durch Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #24628 (project freeciv):

Planned Release: => 3.0.0

_______________________________________________________

Follow-up Comment #1:

Adding new event type (defaulting to popup-output) for this could happen in
TRUNK. Any ideas how to mitigate the problem in stable branches?

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Frank]

Post by Marko Lindqvist
Any ideas how to mitigate the problem in stable branches?

A simple SAVE command is only echoed, i.e., I'm not sure about its effect
(folder + file name). It would be nice to see what happened (in the client
chat window) for a manual save.

If any SAVE fails the server could handle it as "assertion failed", after all
this is just wrong.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Post by Frank
If any SAVE fails the server could handle it as "assertion failed"

Uh, crash and lose the game in the memory too? Keeping server running at least
gives you chance to 1) make another attempt to save the game 2) play it.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Frank]

Follow-up Comment #4, bug #24628 (project freeciv):

Whatever you like better, but I'd consider disk full/offline/read-only as rare
case, where the server presumably has a bigger problem than saving Freeciv
games. :-)

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #5, bug #24628 (project freeciv):

User not having write-permissions to the directory he has chosen as save
directory does not necessarily mean larger server machine problems. Saving can
also fail due to some error in the way freeciv constructs savegame data in
memory, before it even tries to write anything to the disk.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #24628 (project freeciv):

Status: None => Duplicate
Assigned to: None => cazfi
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #6:

Handled at hostedredmine: https://www.hostedredmine.com/issues/657139

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?24628>

_______________________________________________
Message sent via/by Gna!
http://gna.org/