[Freeciv-Dev] [bug #23790] Capital_City is evaluated on the client

[Sveinung Kvilhaugsvik]

URL:
<http://gna.org/bugs/?23790>

Summary: Capital_City is evaluated on the client
Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 16 Aug 2015 12:13:03 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:

_______________________________________________________

Details:

The effect Capital_City may depend on information not sent to the client.
Evaluating it on the client could therefore give the wrong result.




_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Update of bug #23790 (project freeciv):

Status: None => In Progress
Assigned to: None => sveinung
Release: => TRUNK, 2.6, 2.5.1
Operating System: None => Any
Planned Release: => 3.0.0, 2.6.0


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Additional Item Attachment, bug #23790 (project freeciv):

File name: 0001-Don-t-evaluate-Capital_City-on-the-client.patch Size:4 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #1, bug #23790 (project freeciv):

Current patch gives out information far too easily.

Unless embassy is involved:
1) If the player has not seen the capital -> should know no capital
2) If player sees the capital -> should know it
3) If player saw a city as capital, and it's now fogged -> should remember it
(no matter if it's no longer capital, has been conquered by another player or
has even been destoryed)
4) If player saw a now fogged city as capital, and now sees another city of
the same player as capital -> should know that the new information is correct,
and no longer remember fogged city as capital (since there can be max one
capital)
5) If player saw a city as capital, and now sees it again as no-capital
(either after lift of fog, or witnessed disappearance of city's capitalness)
-> should know no capital, unless new one is seen




_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #2, bug #23790 (project freeciv):

This should allow resolving bug #16596 too.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #3, bug #23790 (project freeciv):

Any progress on this?

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #4, bug #23790 (project freeciv):

I've been thinking this, from the perspective of it being, with all required
changes to make it work well, rather big change to S2_6 at this point (one of
the last open issues against npf). In fact, I think this can't be done in S2_6
any more, but it would also require savefile format change (-> must be in a
branch before d3f) for keeping track where the player thinks capital of each
of the opponents to be.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Update of bug #23790 (project freeciv):

Planned Release: 3.0.0, 2.6.0 => 3.0.0

_______________________________________________________

Post by Marko Lindqvist
rather big change to S2_6 at this point

Agreed.

Post by Marko Lindqvist
Any progress on this?

I did some work on storing non map player facts like capital, amount of gold
etc and when it was last seen.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of bug #23790 (project freeciv):

Status: In Progress => Duplicate
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #6:

Handled at hostedredmine: https://www.hostedredmine.com/issues/657128

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?23790>

_______________________________________________
Message sent via/by Gna!
http://gna.org/