[Freeciv-Dev] [patch #8123] civ2civ3: bases give some defense bonus against all unit classes

[David Fernandez]

URL:
<http://gna.org/patch/?8123>

Summary: civ2civ3: bases give some defense bonus against all
unit classes
Project: Freeciv
Submitted by: bardo
Submitted on: Tue 28 Mar 2017 12:52:53 AM UTC
Category: None
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release:
Contains string changes: None

_______________________________________________________

Details:

With this patch, fortresses give +100% defense against land and sea, but also
+50% against air and missile. The opposite for airbases.

Else, I think the units inside bases are too vulnerable against one type of
attack, specially at the final stages of the game.

It also increases the vision radius inside airbases the same than fortresses
with astronomy.

The readme is updated, but the helptext of the bases is not.



_______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 28 Mar 2017 12:52:53 AM UTC Name: civ2civ3-defense_bases-S2_6.patch
Size: 8kB By: bardo

<http://gna.org/patch/download.php?file_id=29905>

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[David Fernandez]

Follow-up Comment #1, patch #8123 (project freeciv):

The change related to river requirement of the airbases is a bug fix, and the
helptext already takes it into account.

The change to readme about happy borders is also a bug fix, they are no longer
disabled.

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Follow-up Comment #2, patch #8123 (project freeciv):

Please submit future tickets to hostedredmine:
http://www.hostedredmine.com/projects/freeciv/issues

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Jacob Nevins]

Update of patch #8123 (project freeciv):

Category: None => rulesets
Planned Release: => 2.6.0, 3.0.0, 3.1.0


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Marko Lindqvist]

Update of patch #8123 (project freeciv):

Assigned to: None => sveinung


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Follow-up Comment #3, patch #8123 (project freeciv):

Parts of this patch (that didn't look relevant to bases) moved to
http://www.hostedredmine.com/issues/657562

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Post by David Fernandez
The change related to river requirement of the airbases is a bug fix

Split out to http://www.hostedredmine.com/issues/657572

Post by David Fernandez
the helptext of the bases is not.

Why?

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Follow-up Comment #6, patch #8123 (project freeciv):

The "why" was aimed at the missing help text changes (quoted above it). I was
trying to find out if the patch was complete or not.

_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[David Fernandez]

Post by David Fernandez
The readme is updated, but the helptext of the bases is not.
Why?

I forgot, you are right, the patch is not really complete. The helptext is not
wrong, but it'd require a more detailed explanation of the new bonus.
I was hoping some english speaker could finish that part, but I can try to
rewrite it. I'll do another version of the patch.




_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[David Fernandez]

Follow-up Comment #8, patch #8123 (project freeciv):

This patch includes the same changes for sandbox, and updated helptexts. (Not
included changes splited to other tickets).

(file #29959)
_______________________________________________________

Additional Item Attachment:

File name: civ2civ3-defense_bases-v2-trunk.patch Size:11 KB


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Update of patch #8123 (project freeciv):

Status: None => Ready For Test
Contains string changes: None => Yes


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

[Sveinung Kvilhaugsvik]

Update of patch #8123 (project freeciv):

Status: Ready For Test => Done
Open/Closed: Open => Closed


_______________________________________________________

Reply to this item at:

<http://gna.org/patch/?8123>

_______________________________________________
Message sent via/by Gna!
http://gna.org/