[Freeciv-Dev] [bug #25246] usdlg memory leak

Discussion:

Marko Lindqvist

2016-10-30 18:28:15 UTC

URL:
<http://gna.org/bugs/?25246>

Summary: usdlg memory leak
Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 30 Oct 2016 08:28:15 PM EET
Category: client-gtk-3+
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: S2_6 r34290
Discussion Lock: Any
Operating System: None
Planned Release:
Contains string changes: None

_______________________________________________________

Details:

==12941== 1,664,160 (5,280 direct, 1,658,880 indirect) bytes in 60 blocks are
definitely lost in loss record 23,981 of 23,981
==12941== at 0x4C2ABAF: malloc (vg_replace_malloc.c:299)
==12941== by 0x898FDE8: g_malloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x89A8322: g_slice_alloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x89A894D: g_slice_alloc0 (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x87202B3: g_type_create_instance (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941== by 0x87021FA: ??? (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941== by 0x870410D: g_object_new_valist (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941== by 0x87043B0: g_object_new (in
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5000.1)
==12941== by 0x813E9AF: gdk_pixbuf_new_from_data (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941== by 0x813C10D: gdk_pixbuf_new (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941== by 0x22506A: usdlg_tab_append_utype (unitselect.c:693)
==12941== by 0x22506A: usdlg_tab_update (unitselect.c:634)
==12941== by 0x22538D: usdlg_refresh (unitselect.c:353)

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Marko Lindqvist

2016-10-30 18:31:07 UTC

Permalink

Follow-up Comment #1, bug #25246 (project freeciv):

usdlg_tab_append_utype() -> gdk_pixbuf_new() is part of also other loss
records. For example:

==12941== 635,904 bytes in 23 blocks are indirectly lost in loss record 23,976
of 23,981
==12941== at 0x4C2ABAF: malloc (vg_replace_malloc.c:299)
==12941== by 0x813C0DC: gdk_pixbuf_new (in
/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.3600.0)
==12941== by 0x22506A: usdlg_tab_append_utype (unitselect.c:693)
==12941== by 0x22506A: usdlg_tab_update (unitselect.c:634)
==12941== by 0x22538D: usdlg_refresh (unitselect.c:353)
==12941== by 0x1EFB11: update_unqueue (update_queue.c:319)
==12941== by 0x161479: idle_callback_wrapper (gui_main.c:2177)
==12941== by 0x898A689: g_main_context_dispatch (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x898AA3F: ??? (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x898AD61: g_main_loop_run (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.1)
==12941== by 0x6BC1804: gtk_main (in
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.2)
==12941== by 0x16414E: ui_main (gui_main.c:1821)
==12941== by 0x18C4C3: client_main (client_main.c:679)

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Marko Lindqvist

2017-04-30 09:38:40 UTC

Permalink

Update of bug #25246 (project freeciv):

Assigned to: None => sveinung

_______________________________________________________

Follow-up Comment #2:

These came after rework for unitselunitdlg stuff, I think.

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Sveinung Kvilhaugsvik

2017-05-02 18:01:41 UTC

Permalink

Additional Item Attachment, bug #25246 (project freeciv):

File name: 2.6-and-3.0-unitselect-don-t-initialize-pix-twice.patch Size:1 KB

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Sveinung Kvilhaugsvik

2017-05-04 10:24:34 UTC

Permalink

Update of bug #25246 (project freeciv):

Status: Ready For Test => Fixed
Open/Closed: Open => Closed

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Marko Lindqvist

2017-05-07 21:03:14 UTC

Permalink

pre "Gtk3-client drawing code uses cairo" initialization

Does that indicate that also S2_5 is affected?

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Sveinung Kvilhaugsvik

2017-05-08 12:14:15 UTC

Permalink

Update of bug #25246 (project freeciv):

Status: Fixed => Ready For Test
Open/Closed: Closed => Open
Planned Release: 3.1.0, 3.0.0, 2.6.0 => 3.1.0, 3.0.0, 2.6.0,
2.5.7

_______________________________________________________

Post by Marko Lindqvist
Does that indicate that also S2_5 is affected?

Yes. Gna patch #2715 went into S2_5.

(file #29965)
_______________________________________________________

Additional Item Attachment:

File name: 2.5-unitselect-don-t-initialize-pix-twice.patch Size:1 KB

_______________________________________________________

Reply to this item at:

<http://gna.org/bugs/?25246>

_______________________________________________
Message sent via/by Gna!
http://gna.org/

Sveinung Kvilhaugsvik

2017-05-10 08:20:31 UTC

Permalink